search

videojs / videojs-contrib-ads

A Tool for Building Video.js Ad Plugins
http://videojs.github.io/videojs-contrib-ads/
Other
384 stars 257 forks source link

Docs are wrong #533

Open mayeaux opened 3 years ago

mayeaux commented 3 years ago

Screen Shot 2021-10-12 at 9 30 14 PM

player.one('adended', function() {

        player.ads.endLinearAdMode();
      });

Interesting, because: Screen Shot 2021-10-12 at 9 32 03 PM

Says the event is adend (which it is)

Guess this means the docs are wrong? Also, why can't I star this repo? Thanks

gkatsev commented 3 years ago

If you have an adblocker enabled, it may interfere with github and this repo.

Also, the adend event fires when endLinearAdMode() is called, where-as the example uses adended to call the method. While similarly named, they are separate events.