search

videojs / videojs-contrib-eme

Supports Encrypted Media Extensions for playback of encrypted content in Video.js
Other
203 stars 72 forks source link

feat: Add support for defining custom headers for default license and certificate requests. #76

Closed alex-barstow closed 5 years ago

gkatsev commented 5 years ago

I think headers is too generic. Since it can be passed in via a source object, someone could see it and maybe expect it to be added for all source requests.

alex-barstow commented 5 years ago

@gkatsev Yeah it is definitely too generic. I left it as such until we can establish the following: should we allow headers to be set only on license requests? Or also certificate and key requests?

misteroneill commented 5 years ago

I think we ought to allow custom headers for any of the default requests contrib-eme can make.