Seek to seekable start when before the seekable window

videojs / videojs-contrib-hls

HLS library for video.js

http://videojs.github.io/videojs-contrib-hls/

Other

2.84k stars 793 forks source link

Seek to seekable start when before the seekable window #1260

Closed forbesjo closed 7 years ago

forbesjo commented 7 years ago

Description

Seek to seekable start when before the seekable window

Specific Changes proposed

Instead of seeking to live when doing a bad seek (for example if the seekable shifts while scrubbing) we'll snap to the beginning of the live window.

Requirements Checklist

[x] Feature implemented / Bug fixed
[x] If necessary, more likely in a feature request than a bug fix
- [x] Unit Tests updated or fixed
[x] Reviewed by Two Core Contributors

mjneil commented 7 years ago

Github won't let me comment on the line because no changes were made, but line 468 of playback-watcher.test.js test description is 'seeks to live point if we try to seek outside of seekable' which is not quite true anymore since it may seek to the start of the window depending on where you are trying to seek