Add nvmrc and update travis' chrome reference

videojs / videojs-contrib-hls

HLS library for video.js

http://videojs.github.io/videojs-contrib-hls/

Other

2.84k stars 792 forks source link

Add nvmrc and update travis' chrome reference #1322

Closed gesinger closed 6 years ago

gesinger commented 6 years ago

Requirements Checklist

[X] Feature implemented / Bug fixed
[ ] If necessary, more likely in a feature request than a bug fix
- [ ] Unit Tests updated or fixed
- [ ] Docs/guides updated
- [ ] Example created (starter template on JSBin)
[ ] Reviewed by Two Core Contributors

forbesjo commented 6 years ago

You may need sudo: required

squarebracket commented 6 years ago

Not sure if these fixes will stop errors like this, but I've had sporadic disconnect errors in the past when testing. Maybe we should add browserDisconnectTolerance: 3 to the karma config?

squarebracket commented 6 years ago

Wow, what a roller coaster. Hopefully you still have some hair left cuz I’d have pulled all of mine out.

gesinger commented 6 years ago

Yeah @squarebracket , it's been a fun one. Still have one test to fix, but 12/13 have been resolved. Hopefully have enough hair left for that one, but it may be close.