videojs / videojs-contrib-quality-levels

Other
154 stars 52 forks source link

unable to change quality on stream in newest version #146

Closed dygy closed 10 months ago

dygy commented 10 months ago

Description

i'm unable to change quality, streams runs the same one anyway codepen here.

Steps to reproduce

  1. enter my codepen
  2. check my code
  3. try to push quality buttons down there

Results

Expected

quality can be changed

Actual

quality are still the same even due console log says it's changed, video are still same

versions

videojs

8.6.1

browsers

any

OSes

mac os

plugins

videojs-contrib-quality-levels

dygy commented 10 months ago

it seems i was wrong at understanding arch. i shoud Array.from(qualityLevels).forEach((elem) => { elem.enabled = statement; }); i fought i can enable singe quality and it's all fine, but i should disable all others (maybe improve request???)

gkatsev commented 10 months ago

That's working as expected. We want to be able to select which renditions are enabled or not to give a hind to the ABR algorithm which renditions it's allowed to switch between.

See https://github.com/videojs/videojs-contrib-quality-levels#triggering-the-change-event for switching to a specific rendition.

dygy commented 10 months ago

it's okay, it was just unexpected by me, but when i found out how it work, it's all good. Just not pretty understandable