search

videojs / videojs-contrib-quality-levels

Other
154 stars 52 forks source link

Representation.bandwidth or Representation.bitrate? #147

Open thomasjammet opened 9 months ago

thomasjammet commented 9 months ago

Description

The documentation tells that we need to provide Representation.bitrate (see in README) but it seems that Representation.bandwidth is the right property, (see the source code).

Maybe it's just needed to update the README file.

gkatsev commented 9 months ago

I think the docs need to be updated. I think that piece is a bit confused on whether it's describing the QualityLevel itself or the Representation. The docs should probably describe both in appropriate sections.

thomasjammet commented 9 months ago

Yes that makes sense