fix: Resolve an issue where 'error' events triggered on the player during contrib-ads playback would not be recognized.

videojs / videojs-errors

A video.js plugin that displays error messages to video viewers.

Other

87 stars 29 forks source link

fix: Resolve an issue where 'error' events triggered on the player during contrib-ads playback would not be recognized. #109

Closed misteroneill closed 7 years ago

misteroneill commented 7 years ago

The redispatch change in contrib-ads v5.0 means that all player events are redispatched during ad playback. In this case, this meant that some users would not see error dialog contents during ad playback if there was an error on the player. This addresses that situation by listening for both the aderror redispatch-prefixed event and the regular error event.

Requirements Checklist

[x] Feature implemented / Bug fixed
[ ] Reviewed by Two Core Contributors

marguinbc commented 7 years ago

Question. If an actual ad error occurs, i.e. an IMA 1009 (empty ad response), will this change now cause the dialog box to pop up? Ad errors typically are only logged out to the console so seeing the popup would be an undesirable change.

misteroneill commented 7 years ago

@marguinbc No, because those are triggered as adserror, not aderror. I wondered the same thing. 😄