videojs / videojs-errors

A video.js plugin that displays error messages to video viewers.
Other
87 stars 29 forks source link

fix: Restart timeout monitor if playing when reinitialised #113

Closed mister-ben closed 6 years ago

mister-ben commented 6 years ago

Description

If the player is playing while the plugin is reinitialised, the playback monitor is stopped and will not restart until a play event.

Specific Changes proposed

On (re)initialisation, start the playback monitor immediately if playing.

Requirements Checklist

mister-ben commented 6 years ago

Not sure why travis fails, but the same failures occur on a branch unchanged from master.

mister-ben commented 6 years ago

The test which triggers dispose on the player causes the dispose in afterEach() to fail on 6.

https://github.com/brightcove/videojs-errors/blob/master/test/plugin.test.js#L209