search

videojs / videojs-errors

A video.js plugin that displays error messages to video viewers.
Other
87 stars 29 forks source link

videojs-errors does not work with npm and video.js 6 #116

Closed axten closed 6 years ago

axten commented 6 years ago

Description

The videojs-errors plugin is not registered correctly when using with videojs 6 and npm. The reason is the package json: "video.js": "^5.19.2".

This leads npm to download an own videojs dependency for this plugin that is be used. So videojs 5 gets imported too and videojs 6 doesn't know the errors plugin.

Steps to reproduce

just try:

import videojs from 'video.js';
import errors from 'videojs-errors';

videojs.getPlugin('errors')  //undefined

Results

Expected

plugin works properly.

Actual

videojs-errors is not registered as a plugin and videojs 5 get additionally added to bundle.

versions

videojs: 6.8.0 videojs-error: 3.1.0