fix: ignore progress events

forbesjo commented 5 years ago

Description

Listening to progress events is redundant, this plugin already monitors timeupdate for playhead progress. The error dialog does not pause on open so if playback resumes the error will be cleared by the playhead moving (https://github.com/videojs/video.js/blob/master/src/js/error-display.js#L61).

Remove the progress event listener so the timeout monitor does not reset.

[ ] Feature implemented / Bug fixed
[ ] If necessary, more likely in a feature request than a bug fix
- [ ] Unit Tests updated or fixed
- [ ] Docs/guides updated
[ ] Reviewed by Two Core Contributors

forbesjo commented 5 years ago

This would be a major update since an API is being removed

gkatsev commented 5 years ago

Ah, didn't see your comment about this being a breaking change. I think it'll be better to just make it a no-op and make it a patch/minor release

ldayananda commented 5 years ago

Tested on IE11 and Edge. LGTM