search

videojs / videojs-errors

A video.js plugin that displays error messages to video viewers.
Other
88 stars 29 forks source link

feat: add support for -1 timeout and backgroundTimeout values #206

Closed roman-bc-dev closed 3 years ago

roman-bc-dev commented 3 years ago

Add support for -1 value, in addition to Infinity, to disable timeout and backgroundTimeout features.

misteroneill commented 3 years ago

We can ignore the Snyk integration for this PR and merge it once approved. We'll keep Travis for now until we have a chance to migrate to GitHub Actions.

gkatsev commented 3 years ago

@roman-bc-dev were you using node 14 for this? Is that why the package-lock changed? If so, can we update the .nvmrc file to read lts/fermium?

alex-barstow commented 3 years ago

We've also used .indexOf() as an alternative to .includes() in the past: disableValues.indexOf(options.backgroundTimeout) !== -1

Edit: but seems like consensus supports using .some() in this case :)