videojs / videojs-errors

A video.js plugin that displays error messages to video viewers.
Other
86 stars 28 forks source link

feat: Remove vjs-errors-dialog id #226

Closed roman-bc-dev closed 1 year ago

roman-bc-dev commented 1 year ago

Description

It is currently possible for multiple errors to generate div elements with duplicate vjs-errors-dialog ids.

Specific Changes proposed

Remove code to set vjs-errors-dialog on the generated div that wraps error content. The same string is already used to set a class on that element and the vjs-errors-dialog id is not used for targeting in the plugin or the videojs org.

Requirements Checklist