videojs / videojs-playlist

Playlist plugin for videojs
Other
361 stars 123 forks source link

chore: add ci workflow #242

Closed philjhale closed 1 year ago

philjhale commented 1 year ago

Description

gkatsev commented 1 year ago

What about using the ci template from https://github.com/videojs/.github/blob/main/workflow-templates/ci.yml?

misteroneill commented 1 year ago

Gary makes a good point though!

philjhale commented 1 year ago

What about using the ci template from https://github.com/videojs/.github/blob/main/workflow-templates/ci.yml?

Thanks. I looked at that workflow but wasn't sure if we needed all those steps for a plugin. If we do, it's no problem, I'll update the workflow.

I have a few questions, just for my understanding:

Thanks!

gkatsev commented 1 year ago

Yup, the browserstack credentials are available at the org level. The ffmpeg step may not be stricly necessary, but keeping the action the same across repos is definitely helpful. I'm not sure exactly why it isn't npm ci. My guess is that it might end up being faster due to the caching compared to using npm ci.

philjhale commented 1 year ago

I've updated the workflow based on the video.js template. Interestingly, the CI action hasn't executed. I'm not sure why 🤔