search

videojs / videojs-vr

A plugin to add 360 and VR video support to video.js.
https://videojs-vr.netlify.com/
MIT License
543 stars 145 forks source link

Fix/ios preroll #115

Closed brandonocasey closed 6 years ago

brandonocasey commented 6 years ago

Reset needs to null out variables and dispose, just dispose won't actually reset the plugin. IOS has a special case for many ad plugins that we have to handle.

gkatsev commented 6 years ago

So, should we have the reset code for ads here or should the ad plugins know to reset the VR plugin when enabled? Thoughts @incompl ? We probably want to reset VR when videoElementRecyled is true in contrib-ads, rather than just on iOS, no?

brandonocasey commented 6 years ago

Yeah we probably want to set it whenever videoElementRecycled is true. I would think we would want this plugin to know about ads and not the other way around.

gkatsev commented 6 years ago

We have been trying to keep all ad-related code contained. I'm not sure where it is necessarily better, though.

apadhye commented 6 years ago

QA LGTM