search

videojs / videojs-vr

A plugin to add 360 and VR video support to video.js.
https://videojs-vr.netlify.com/
MIT License
541 stars 143 forks source link

Future of the motion controls option #255

Open romaricpascal opened 2 years ago

romaricpascal commented 2 years ago

Hi!

I've noticed that ThreeJS has removed the DeviceOrientationControls from their codebase. I was wondering which impacts (if any) it would have on videojs-vr continuing to support motion controls for viewing 360 videos?

gkatsev commented 2 years ago

It's definitely going to be an issue. We already don't really have the bandwidth to maintain this project. The last time I updated threejs (https://github.com/videojs/videojs-vr/pull/249) I've had trouble and it potentially broke some things. I did vendor some files but I think it's a bit more complicated to get things updated for the future.

Smidgens commented 2 years ago

It's definitely going to be an issue. We already don't really have the bandwidth to maintain this project. The last time I updated threejs (#249) I've had trouble and it potentially broke some things. I did vendor some files but I think it's a bit more complicated to get things updated for the future.

Is this something that could be offloaded to a separate package? Like if say, videojs-vr didn't come included with camera or motion controls, but provided some kind of plugin interface for people to implement or install their own? I'm using three.js by itself in another project, and if I recall, I needed to copy and modify the default motion controls due to some niche platform issues I was having. I'm not sure how I'd go about doing something like that with videojs-vr at the moment.