fix: implement touch pan controls again

videojs / videojs-vr

A plugin to add 360 and VR video support to video.js.

https://videojs-vr.netlify.com/

MIT License

543 stars 145 forks source link

fix: implement touch pan controls again #89

Closed brandonocasey closed 6 years ago

brandonocasey commented 6 years ago

Description

Recently webvr-polyfill removed support for the touch panner controls that they used to add to their polyfill vr headset. This PR brings them back.

Testing

Make sure that the latest versions of every browser can move around the video with touch controls or mouse
- [ ] iOS Safari
- [ ] Android Chrome
- [ ] Safari
- [ ] Chrome
- [ ] Firefox
Make sure that mobile browsers can move around the video by physically moving the phone:
- [ ] iOS Safari
- [ ] Android Chrome

ishita12 commented 6 years ago

QA LGTM

danielgroppo commented 6 years ago

Hello,

Sorry or my newbie question, I'm little bit confused how to make it works (movement with the mouse/touch). I incorporated the videojs-vr.min.js script to my page and the player worked perfectly with gyroscope. If I just add the plugin.js and the movements will work? What files should I complement?

Again, apologies for the rookie question, feel free to delete if you are in the wrong place. Thank you for this great project.