search

videojs / videojs-youtube

YouTube playback technology for Video.js
1.13k stars 549 forks source link

An in-range update of video.js is breaking the build 🚨 #529

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency video.js was updated from 7.4.0 to 7.4.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

video.js is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/videojs/videojs-youtube/builds/472399400?utm_source=github_status&utm_medium=notification)).
Release Notes for v7.4.1

7.4.1 (2018-12-11)

Bug Fixes

Chores

  • package: update autoprefixer to version 9.4.2 (#5647) (19f3465)
  • package: update rollup-plugin-node-resolve to version 4.0.0 🚀 (#5666) (d07b6c2)

Documentation

  • remove grunt and update usage of build scripts (#5656) (62f9e78)

Tests

  • verify null-checks with player and control bar children set to false (#5670) (13b42ad)
Commits

The new version differs by 14 commits.

  • bc7d530 7.4.1
  • 165c120 fix(a11y): make seek-to-live better announce itself to screen reader users (#5651)
  • 13b42ad test: verify null-checks with player and control bar children set to false (#5670)
  • 70a71ae fix(a11y): fix hidden Control Text in Progress bar (Fixes #5251) (#5655)
  • 8932611 fix(a11y): current time and duration display accessibility with VoiceOver (#5653)
  • b9d8744 fix(lang): improves sv lang file (#5673)
  • d07b6c2 chore(package): update rollup-plugin-node-resolve to version 4.0.0 🚀 (#5666)
  • dce4a2c fix(liveui): make edge detection less strict, add docs for option (#5661)
  • 98b4a1c fix(lang): Update sr.json (#5657)
  • 8c9702a fix(package): update @videojs/http-streaming to version 1.5.1 🚀 (#5658)
  • 831961b fix(liveui): seek to live should be immediate and other tweaks (#5650)
  • 62f9e78 docs: remove grunt and update usage of build scripts (#5656)
  • b7aafdc fix(lang): append UKR translations and fix check translations command (#5642)
  • 19f3465 chore(package): update autoprefixer to version 9.4.2 (#5647)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.4.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

gkatsev commented 5 years ago

Failing due to something else, plus, we want to keep it to be ^6 || ^7.