videojs / videojs-youtube

YouTube playback technology for Video.js
1.13k stars 547 forks source link

Update component to be compatible with VideoJS 8.0.4+ #606

Closed mattporritt closed 1 year ago

mattporritt commented 1 year ago

The videojs.extend() function is removed from Video.js 8.0 See: https://videojs.com/guides/videojs-7-to-8/#videojsextend This patch reworks code to be an ES6 Class.

Fixes #604

Plugin unit tests also pass, and have tested with a videojs 8.0.4 implementation

astagi commented 1 year ago

@gkatsev @eXon @revolunet I tried this PR and it works like a charm for VideoJS 8.0.4! Could you please merge it and release a major version? We're already using it in the Italian Design System https://github.com/italia/bootstrap-italia/pull/841

Thank you @mattporritt

mattporritt commented 1 year ago

Hi @gkatsev , Thanks for your patience on this. I've made the changes you've requested. I've rewritten and forced pushed so everything is still in one commit.

Cheers, Matt P

gkatsev commented 1 year ago

Published as 3.0.0!