videokit-ai / natshare

Cross-platform social sharing for Unity Engine.
https://github.com/natmlx/videokit
Apache License 2.0
134 stars 28 forks source link

Added text captions and pause action when share sheet launched #56

Closed handcircus closed 5 years ago

handcircus commented 5 years ago

Added support for text captions with images and pause when launch Share Sheet

olokobayusuf commented 5 years ago

Overall this looks pretty good. I'm crafting an entirely new API, so I won't merge this (see #49). One interesting question I have is on the decision to pause Unity engine. Why?

handcircus commented 5 years ago

Great to know about the new API with text support. We didn't want the game running in the background while share sheet popped up, so preferred using UnityPause when anything system-level is running (we've done the same with email, webview etc). Might be adding as an option?

olokobayusuf commented 5 years ago

Ah I guess that's fair. I'll make this the default behaviour.