Closed 1480c1 closed 4 years ago
Hi, thanks for your patch!
I have no objection, could you squash your 1st commit and its fixup though?
Done
Oh I didn't mean all commits, just the fixup!
one, with the commit it was fixing up.
I don't remember precisely if the 2nd was also a fixup, and the 4th was definitely fixing something else (not hardcoding the include/
directory)
Ideally if you could restore the 4th one as a separate commit that would be better, otherwise LGTM
I'll let a bit of time for other contributors to voice their opinion before merging
The 4th commit's been restored, I left the 2/3 one's squashed into the first one since they affect the same thing
Perfect, thanks a lot :)
Currently, the resulting pkg-config files have
because the find_* commands are failing and are not properly checked
final result is