Cmake: Fix mysofa finding and variables

videolabs / libspatialaudio

Ambisonic encoding / decoding and binauralization library in C++

Other

198 stars 37 forks source link

Closed 1480c1 closed 4 years ago

1480c1 commented 4 years ago

Currently, the resulting pkg-config files have

Libs: -L${libdir} -lspatialaudio -LMYSOFA_ROOT_DIR-NOTFOUND/lib -lmysofa -lm -lz
Cflags: -I${includedir} -IMYSOFA_ROOT_DIR-NOTFOUND/include

because the find_* commands are failing and are not properly checked

final result is

Libs: -L${libdir} -lspatialaudio -L/usr/lib/x86_64-linux-gnu -lmysofa -lm -lz
Cflags: -I${includedir} -I/usr/include

chouquette commented 4 years ago

Hi, thanks for your patch!

I have no objection, could you squash your 1st commit and its fixup though?

1480c1 commented 4 years ago

Done

chouquette commented 4 years ago

Oh I didn't mean all commits, just the fixup! one, with the commit it was fixing up.

I don't remember precisely if the 2nd was also a fixup, and the 4th was definitely fixing something else (not hardcoding the include/ directory)

Ideally if you could restore the 4th one as a separate commit that would be better, otherwise LGTM

I'll let a bit of time for other contributors to voice their opinion before merging

1480c1 commented 4 years ago

The 4th commit's been restored, I left the 2/3 one's squashed into the first one since they affect the same thing

chouquette commented 4 years ago

Perfect, thanks a lot :)