search

videolang / video

Source Code for Video language.
https://lang.video
Apache License 2.0
125 stars 12 forks source link

Fixed case in multitrack when new-end is infinite #23

Closed BenChung closed 6 years ago

BenChung commented 6 years ago

Multitrack was previously computing the end of videos incorrectly, causing the trivial case (where the end of a video to composite was infinite, therefore the length of the combined video should not change) to cause a crash, due to the unless function returning void when the given condition is satisfied.

This change replaces the unless condition in multitrack with an if statement, correctly leaving the length unchanged when a clip of arbitrary length is composited with a track of a known length.

LeifAndersen commented 6 years ago

LGTM. The tests are failing because the server travis uses to get the racket builds seems to be failing. I will go ahead and merge this.