videolang / video

Source Code for Video language.
https://lang.video
Apache License 2.0
125 stars 12 forks source link

edit paragraph #28

Open CAHollenbeck opened 6 years ago

CAHollenbeck commented 6 years ago

"language declaration" may need to be called something else, but I'd like some similar description of what it is.

LeifAndersen commented 6 years ago

Thanks for the PR. I added comments in the code.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 87.138% when pulling 285b97d235dd29cf4142ee3ee7de2895b0b84510 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

codecov[bot] commented 6 years ago

Codecov Report

Merging #28 into master will decrease coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   87.13%   87.01%   -0.13%     
==========================================
  Files          41       41              
  Lines        6251     6345      +94     
==========================================
+ Hits         5447     5521      +74     
- Misses        804      824      +20
Impacted Files Coverage Δ
video/private/opengl.rkt 68.8% <0%> (-4%) :arrow_down:
video/private/video-canvas.rkt 79.39% <0%> (-2.82%) :arrow_down:
video/private/installer.rkt 22.58% <0%> (-2.42%) :arrow_down:
video/private/video.rkt 79.71% <0%> (-1.14%) :arrow_down:
video/base.rkt 91.19% <0%> (-0.92%) :arrow_down:
video/private/ffmpeg/constants.rkt 98.8% <0%> (-0.09%) :arrow_down:
video/core.rkt 100% <0%> (ø) :arrow_up:
video/private/ffmpeg-pipeline.rkt 88.93% <0%> (+1.27%) :arrow_up:
video/render.rkt 85.49% <0%> (+1.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1936d02...f5880ec. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 87.138% when pulling 285b97d235dd29cf4142ee3ee7de2895b0b84510 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 86.594% when pulling 285b97d235dd29cf4142ee3ee7de2895b0b84510 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 87.138% when pulling a84286c1718ee3319e00f127539b3f1d1556d5c1 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 13176661966fefc498d7e0e76a41ba0498bbca67 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 1a5edd861f355eecb07ed6d9f5a26a9c6781b01e on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.544% when pulling 1a5edd861f355eecb07ed6d9f5a26a9c6781b01e on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 1a5edd861f355eecb07ed6d9f5a26a9c6781b01e on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 19e686da042cbd2fde9534b7d33c4868a9b7835d on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.544% when pulling 19e686da042cbd2fde9534b7d33c4868a9b7835d on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.544% when pulling f996d280dfb1f8e9b60ee29d8e13730ed8c5ee71 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.544% when pulling f996d280dfb1f8e9b60ee29d8e13730ed8c5ee71 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling f996d280dfb1f8e9b60ee29d8e13730ed8c5ee71 on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 0374e1459bbdc62f7cd0d7ae63796c69e36d757e on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

LeifAndersen commented 6 years ago

What is your reasoning for moving the Multitracks and merges section to before transitions? Given that transitions only apply to playlists it seems silly to start with playlists, jump to multitracks, and then cover transitions.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 0374e1459bbdc62f7cd0d7ae63796c69e36d757e on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.528% when pulling 17e72c31b278b505a2d16abe401733ac07e79c0a on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 86.528% when pulling 17e72c31b278b505a2d16abe401733ac07e79c0a on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 87.088% when pulling 17e72c31b278b505a2d16abe401733ac07e79c0a on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

LeifAndersen commented 6 years ago

Looking at your commit message, it looks like you answered my previous message:

What is your reasoning for moving the Multitracks and merges section to before transitions? Given that transitions only apply to playlists it seems silly to start with playlists, jump to multitracks, and then cover transitions.

multitracks are mentioned before transitions in Playlists, so Multitr…

Anyway, this seems odd to me, since transitions are more closely bound (logically) to playlists. Thus, it seems very odd to me to have:

The order:

Makes more more sense to me. If you want, you could merge them so that the structure is more like:

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.013% when pulling f5880ecf967e5b0ffb33b9ab3f1094ed79f6242b on CAHollenbeck:master into 1936d021101f1d6772f20bcbde2bdec18ebdd7db on videolang:master.

LeifAndersen commented 6 years ago

Has there been any more progress on this?

LeifAndersen commented 6 years ago

Just another quick ping to here about the status of this PR.