videosegmentation / video_segment

Main repository for The Video Segmentation Project
Other
167 stars 80 forks source link

Fix render level passing bug in Segment Render #12

Closed JosephRedfern closed 9 years ago

JosephRedfern commented 9 years ago

Absolute level was previously being worked out (on line 265, using the --render_level flag), but not being passed to RenderRegionsRandomColour.

Instead, FLAGS_render_level (in the range [0..1]) was being passed, which is the wrong value to use (unless --render_level was set to 0). The scaled value, absolute_level, should be used.

This commit fixes this issue by passing absolute_level rather than FLAGS_render_level to the RenderRegionsRandomColor call.

(I'm 99% sure this is a bug, apologies if it's just that I've missed something..!)

dcastro9 commented 9 years ago

I had run into this bug before, thanks for fixing that, merged.