search

vidhi110 / TipIT

Tip calculator
0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 7 years ago

codepathreview commented 7 years ago

Thanks for submitting your pre-work, but could you make some changes to your readme? Can you please review the section in the pre-work about the readme for your project?

In particular, be sure to start from the README template that is linked there, check off your completed required and optional features ([x]), list any additional features, and include a recorded app walkthrough with LiceCap.

Please re-submit your project on your application dashboard, and it will notify us to review again.

vidhi110 commented 7 years ago

Hi I did added a readme. Are you not able to see it? Only thing remaining was video link. Let me know

vidhi110 commented 7 years ago

I think something like this happened https://stackoverflow.com/questions/16930685/recover-overwritten-git-commit-lost-by-force-push I missed that I had readme commit from github.com and when i got a push rejection i thought may be cz of some issue of i just did force push :( Can I recover it any ways? Had written a big readme :( feel so stupid

vidhi110 commented 7 years ago

@codepathreview Was able to recover it. :)

vidhi110 commented 7 years ago

Other files also got added in the changes which generated from running in simulator. I am trying to remove if so that it files changes in commit looks clean. If not then two files which has main logic is ViewController and SettingsViewController plus main.storyboard.

codepathreview commented 7 years ago

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of iOS development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

Great to see you were able to complete some optional features to your app already. The optional tasks available on each project are often the most valuable learnings since they dive deeper into common real-world iOS use cases. We encourage you to continue working on extensions to your tip calculator as a way to further explore iOS development.

See if you can expand the functionality of the app or instead work to improve the user interface by experimenting with colors, spacing, styling, icons, etc. You can update your submission at any time here, and it will notify us to review again.

We'll be following up with you again shortly to outline the next steps in the admissions process.

/cc @codepathreview