vidify / old-audiosync

First implementation of the audio synchronization feature for Vidify, now obsolete
GNU Lesser General Public License v3.0
17 stars 3 forks source link

Return success/fail rather than zero #13

Closed marioortizmanero closed 4 years ago

marioortizmanero commented 4 years ago

Returning zero in the module when the cross_correlation fails makes sense because Vidify will do nothing. But if the audio synchonization was actually zero (and it didn't fail), this would count as an error and nothing would be done, rather than applying the extra delays (self.yt_delay, self.config.audiosync_calibration and self.player_delay). As unlikely as this can be, it should be fixed.