Returning zero in the module when the cross_correlation fails makes sense because Vidify will do nothing. But if the audio synchonization was actually zero (and it didn't fail), this would count as an error and nothing would be done, rather than applying the extra delays (self.yt_delay, self.config.audiosync_calibration and self.player_delay). As unlikely as this can be, it should be fixed.
Returning zero in the module when the
cross_correlation
fails makes sense because Vidify will do nothing. But if the audio synchonization was actually zero (and it didn't fail), this would count as an error and nothing would be done, rather than applying the extra delays (self.yt_delay
,self.config.audiosync_calibration
andself.player_delay
). As unlikely as this can be, it should be fixed.