Consider switching back to C++ - Githubissues

vidify / old-audiosync

First implementation of the audio synchronization feature for Vidify, now obsolete

GNU Lesser General Public License v3.0

17 stars 3 forks source link

Consider switching back to C++ #23

Closed marioortizmanero closed 4 years ago

marioortizmanero commented 4 years ago

I went from C++ to C for performance but to be honest I'm not sure if it was a good choice. Here are some points to consider switching back:

Positive

More portable threading, easier to use and understand (no structs and etc), std::atomic<global_status_t> for global status variable (could even make it a bit faster, but probably unnoticeable).
Better standard library and more flexibility: vectors, stoi instead of hardcoding MAX_SECONDS_STR, avoiding strcat, strcpy etc (in linux_download.c).
Constexpr instead of macros (much safer).

Negative

Worse performance? -> has to be tested with benchmarks and godbolt

Other ideas:

Maybe only parts of the code in C for performance (cross_correlation.c). Otherwise, the FFTW C++ bindings could be used https://github.com/dealias/fftwpp.
Depends on what other libraries I end up using, and what languages they are available for.

marioortizmanero commented 4 years ago

I think it's going to be easier to just use C. Both PulseAudio and libav are in C, so using bindings for everything will over-complicate the code IMO. C it is, for now.