vidify / old-audiosync

First implementation of the audio synchronization feature for Vidify, now obsolete
GNU Lesser General Public License v3.0
17 stars 3 forks source link

Not working with noisy audio #39

Closed marioortizmanero closed 4 years ago

marioortizmanero commented 4 years ago

Many times the music videos have intros with noise, or maybe they're recorded live and the crowd can be heard. This module won't work with these types of issues, and I'm not sure what could be done. I'm creating this issue in case I come up with something, or if someone wants to suggest an idea.

Edit: I was suggested to determine individual regions of maximum correlation, and then resample the region to have them match the timing, rather than shifting the signals. This is because Cooley-Tuckey FFT already chunks the signals in N samples in time, where N is a power of 2.

I should read a book about Digital Signal Processing to understand it better first, so I'll revisit this issue in the future.

Edit: this is going to take a long time because I have to learn new concepts before programming them. Some methods and ideas to consider in order to fix this:

Other resources:

marioortizmanero commented 4 years ago

Closing issue: see #53