Closed JuryA closed 9 months ago
Hi @JuryA, great to see you here (again). Thank you for this PR!
Currently the gated pipeline fails with this syntax problem:
[ERROR] templates/: parse error at (hull-test/charts/hull/templates/_util.tpl:51): unexpected "{" in operand
Error: 1 chart(s) linted, 1 chart(s) failed
I am not sure if I can make the errors from our internal pipelines more transparent, will need to check this.
You should also be able to run the tests locally of course, sadly I think the documentation on that is lacking. Will look into it. If you need help on executing tests locally I am happy to help, personally I run them using VSCode and the Gauge plugin which is pretty convenient.
@JuryA I am preparing the next releases to be out this week,
Do you want me to incorporate above changes into the next releases or do you plan on contributing more work on this PR since it is currently still in draft mode?
@JuryA The proposed code changes have been manually merged to the latest releases. I will close this PR for now.
Thank you! I must admit that there were a few issues I overlooked in my initial review. I hope you were able to identify them. Currently, I am fully engaged with my regular work commitments, which unfortunately leaves me with limited availability to address these activities at the moment. I appreciate your understanding and patience.
This pull request presents an extensive array of refinements within the Hull Named Templates, with special emphasis on enhancing intuitiveness. The principal updates are as follows:
Refinement of
hull.util.merge
:_util.tpl
.Enhancement of
hull.util.field
:Simplification of
hull.util.yaml
:Refinement of
hull.util.include.k8s
:$hullObjectBaseKeys
,$hullObjectKeys
, and$spec
to more suitable locations.Elimination of Trailing Whitespaces in Template Comments:
By emphasizing intuitiveness, this PR significantly improves the readability, maintainability, and efficiency of the Helm helper function templates' code.