search

vidit-sh / redux-sentry-middleware

Redux middleware for propagating Redux state/actions to use with new @sentry/browser and @sentry/node.
79 stars 16 forks source link

Fix - change scope to event to add tags to sentry request #5

Closed munroTom closed 5 years ago

munroTom commented 5 years ago

Middleware was not adding tags to events posted to Sentry as the tags were being added to the scope instead

kirisanth-g commented 5 years ago

Any update on this PR?

vidit-sh commented 5 years ago

@munroTom @kirisanth-g why should this be changed? I see the point of uniformity, though could you justify your change making any feature useless without this change?

vidit-sh commented 5 years ago

Also did you get a chance to see if this is breaking anything?

munroTom commented 5 years ago

@vidit-sh without this change the middleware won't attach any tags to the request when it captures an error meaning the getTags part of the library doesn't work at all

I've made the changes on a local copy and been running it since the creation of this PR and haven't experienced any issues

munroTom commented 5 years ago

@vidit-sh done

vidit-sh commented 5 years ago

thanks @munroTom, change merged and version published.