vidma
commented
11 years ago Hi, Great to see someone contributing to this project! I'm sure there's still lots of work and opportunities for improving it.
The changes look good.
By the way, I suggest you to include a compiled apk into further commits to allow easier testing. (For instance, I didn't use android toolkit for a while and I am quite lazy/busy to install it now).
P.s. The location of data files is hard coded in the source (see PreferencesActivity and main activity. APP_CONTENT_FILE_DOWN_URL) and currently points to a manually created zip file (uploaded on hit hub).
Further if I remember well, for android market users, I'm hosting copy this zip file on android market itself.
Cheers, Vidmantas On Dec 23, 2012 12:22 PM, "Pablo Duboue" notifications@github.com wrote:
Salut!
I'd like to give AAC Speech Android a little bit of NLG love.
I started by working on the prepositions. This pull request goes together with a patch (http://pastebin.com/ZtFuZ4Sr) to icon_meanings.data (maybe categories.data and icon_meanings.data could be kept in a different branch?).
Si vous voulez on peut travailler ensemble. Je pense que les extensions qui M. Vaudry a faite a SimpleNLG devons d'être ajouter a la version officielle de SimpleNLG et que AAC Speech Android pourrait donc utiliser une version sans modifications de SimpleNLG pour profité immédiatement de quel-qu’autres nouvelles améliorations.
Je pense que le projet se très intéressante et il peut être possible de penser en faire aussi une version en espagnol :-)
Cordialement,
P.
You can merge this Pull Request by running:
git pull https://github.com/DrDub/aac-speech-android master
Or view, comment on, or merge it at:
https://github.com/vidma/aac-speech-android/pull/25 Commit Summary
- Fixed [I, you] goes into "I and you", still need to work on it to get…
- Prepositions should now be working.
File Changes
- A .gitignore (2)
- _M_source/libs/simplenlg/syntax/AbstractCoordinatedPhraseHelper.java (7)
- M source/src/com/epfl/android/aac_speech/data/Pictogram.java (7)
- M source/src/com/epfl/android/aac_speech/nlg/Pic2NLG.java (11)
Patch Links
- https://github.com/vidma/aac-speech-android/pull/25.patch
https://github.com/vidma/aac-speech-android/pull/25.diff
— Reply to this email directly or view it on GitHubhttps://github.com/vidma/aac-speech-android/pull/25.
Salut!
I'd like to give AAC Speech Android a little bit of NLG love.
I started by working on the prepositions. This pull request goes together with a patch (http://pastebin.com/ZtFuZ4Sr) to icon_meanings.data (maybe categories.data and icon_meanings.data could be kept in a different branch?).
Si vous voulez on peut travailler ensemble. Je pense que les extensions qui M. Vaudry a faite a SimpleNLG devons d'être ajouter a la version officielle de SimpleNLG et que AAC Speech Android pourrait donc utiliser une version sans modifications de SimpleNLG pour profité immédiatement de quel-qu’autres nouvelles améliorations.
Je pense que le projet se très intéressante et il peut être possible de penser en faire aussi une version en espagnol :-)
Cordialement,
P.