Space suman

[suman111]

could you please go through this app and let us know if any modification needed?

[vidma]

wow that's big! and exciting I hope!:)

it would have been cool to separate into commits. at least the changes that are mechanic (autogen'ed files, moving thousands of images) could be separated.

But I'll try to find time to take a look at this! Cheers

[vidma]

finally found some time to take a look.

some things noticed after playing shortly with app-debug.apk :

• after installing it, screen stays white for very long until extraction % status bar appears (maybe this is due to debug?)
• French language seems not to work anymore... !?
• clear search symbol (X) opens search

the rest looks 🆗. It's good to remove the history tab.

what do you mean by check buttons is not set ?

[suman111]

1. The white screen (permission is not granted) is because of the new security update from android. In marshmallow and above android apps must grant permission on starting of the app. I can fix it in next commit.
2. I don't know french or later anybody can add.
3. Check buttons in preferences menu is not working now.

It was a beta version, needed to do many works.

On 9 April 2018 at 23:34, vidma notifications@github.com wrote:

finally found some time to take a look.

some things noticed after playing shortly with app-debug.apk :

• after installing it, screen stays white for very long until extraction % status bar appears (maybe this is due to debug?)
• French language seems not to work anymore... !?
• clear search symbol (X) opens search

the rest looks 🆗. It's good to remove the history tab.

what do you mean by check buttons is not set ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vidma/aac-speech-android/pull/65#issuecomment-379841261, or mute the thread https://github.com/notifications/unsubscribe-auth/AOet1TFtSljPQILZ44nRgfm3EFTKdU2sks5tm6KVgaJpZM4Lq6Jx .

-- Regards, Suman Dev