vidstack / player

UI components and hooks for building video/audio players on the web. Robust, customizable, and accessible. Modern alternative to JW Player and Video.js.
https://vidstack.io
MIT License
1.9k stars 114 forks source link

Doesn't work without installing dashjs #1225

Closed DerStimmler closed 3 months ago

DerStimmler commented 3 months ago

Current Behavior:

Can't use the player without installing dashjs.

Error: node_modules/.pnpm/vidstack@1.11.6/node_modules/vidstack/dist/types/vidstack-Co2t7r7t.d.ts:3:23 - error TS2307: Cannot find module 'dashjs' or its corresponding type declarations.

3 import * as DASH from 'dashjs';
                        ~~~~~~~~

× Failed to compile.

When I install dashjs v4.7.4 the build succeeds.

Expected Behavior:

Should be able to use vidstack with hls.js without installing dashjs.

Steps To Reproduce:

Install vidstack v1.11.6 and use it with hls.js. Don't install dash.js.

Environment:

mihar-22 commented 3 months ago

We can't remove those types but from your end it shouldn't be an issue. I think skipLibCheck is missing in your tsconfig?

DerStimmler commented 3 months ago

That's it. Thanks.