Plyr Layout broken with Web Component

moomerman commented 6 months ago

Current Behavior:

I've just upgraded from 1.10.9 to 1.11.7 and the Plyr Layout has broken.

Using the Web Component example from the docs:

<media-player title="Sprite Fight" src="https://files.vidstack.io/sprite-fight/720p.mp4">
  <media-provider></media-provider>
  <media-plyr-layout thumbnails="https://files.vidstack.io/sprite-fight/thumbnails.vtt"></media-plyr-layout>
</media-player>

on 1.10.9 this renders as

But with 1.11.7 it is

There are no errors in the console.

The Default Layout works as expected. If I focus the black video area and press spacebar the video plays.

Expected Behavior:

I expected the layout to remain the same after upgrading.

Steps To Reproduce:

Follow the example in the docs to install using the Web Component and Plyr Layout.

Environment:

Framework: Web Component
Node: 20.12.0
OS: macOS:14.4.1
Browser: Safari@17.4.1

mihar-22 commented 6 months ago

Ah wow, messed up our bundles 😓 Sorry about that! Pushing out fix in a moment, just looking at two other important bugs.

iamlaristo commented 5 months ago

@mihar-22 i'm still experiencing the same issue on 1.11.17, was it merged or did I miss something?

mihar-22 commented 5 months ago

Hey @iamlaristo! It seems all good on my end and user reports mentioned it's working fine now. Make sure there isn't any caching messing things up on your end. Delete node_modules, hard reload browser, and purge any network layer caches. If it persists, feel free to try and create a repro. I'll have another look tomorrow just incase.

vidstack / player