vidstack / player

UI components and hooks for building video/audio players on the web. Robust, customizable, and accessible. Modern alternative to JW Player and Video.js.
https://vidstack.io
MIT License
2.15k stars 126 forks source link

Videoplayer GUI broken when rendering the video as a HTMLDialogElement #1301

Closed taran2k closed 3 months ago

taran2k commented 3 months ago

Current Behavior:

Given that the options (Quality, Speed, etc.) pop-over, that should be displayed when the gear icon is clicked within the video player GUI, renders as a HTMLElement, it by definition will always render below a HTMLDialogElement. This in term leads to the options pop-over rendering behind the video, making it practically unusable.

Expected Behavior:

For the options pop-over to render on top of the video player.

Environment:

Anything Else?

See HTMLDialogElement documentation

taran2k commented 3 months ago

@mihar-22 Thanks for the swift work. Unfortunately, to no avail. I've reopened the issue under #1319.