search

vidstige / NRasterizer

OpenType parser in pure c#
Apache License 2.0
38 stars 11 forks source link

compat with .NET >=2 on Windows #14

Closed prepare closed 7 years ago

vidstige commented 7 years ago

Thank you!

  1. Some comments to adress
  2. Test is failing. Why? Try to make green if possible. I will change the tests so that they instead use the new and shiny interface instead, but for now please make then green.
  3. Rebase branch, too many master merges :-) See below

How to rebase

  1. git checkout -b dotnet-2.0-rebased # create new branch to avoid force pushing
  2. git fetch upstream # make sure you've got latest master
  3. git rebase upstream/master # rebase, this will remove master merge commits.
  4. git push # push to github
  5. Create new pull request from new branch.
vidstige commented 7 years ago

You can (and should )also run test locally from visual studio :+1:

prepare commented 7 years ago

@vidstige Test on local machine I can't fix the error that occurs in xaml project. I'm not familiar with xaml :( but I think its because of namespace name of existing rendering elements have changed to NRasterizer.NRasterizer

err2_on_net20

do you have any idea it fix it?

vidstige commented 7 years ago

The WPF is not being built by build server. I introduced those errors.... Click "Details" to see actual error message. One or more unit tests fail...

See the following link on how to run tests locally: http://nunit.org/index.php?p=vsTestAdapter&r=2.6.4

vidstige commented 7 years ago

You can also run from command line like on travis. See .travis.yml file for more info. But I recommend installing the NUnit test adapter.

vidstige commented 7 years ago

I merged my branch. I added x and y parameters to decide where to draw letter. Needed for multi-char support. Should be an easy merge. Sorry for inconvenience.

prepare commented 7 years ago

@vidstige , errors on test case because, the GlyphPathBuilder dose not use the contour, line-segment etc.

err3_on_net20

what should I do?

vidstige commented 7 years ago

Alright, your too slow I pushed some fixes. I'll fix the merge problem now,

vidstige commented 7 years ago

Alright, it all seems to work now. Compiles and unit tests green! ✅ I also rebased for cleaner history in #16. Enjoy! :-)

vidstige commented 7 years ago

Sorry if I seem harsh in my messages. It's just my baby project and I want to keep it clean and slick. But I do appreciate all your contributions. Hope you understand! :-)