vidstige / NRasterizer

OpenType parser in pure c#
Apache License 2.0
38 stars 11 forks source link

fixed, calculate glyphIdArrayLength #28

Closed prepare closed 7 years ago

prepare commented 7 years ago

this is better than the old one, since cmap provide length field,

(I just notice that today. then the Its easy to find the end of the cmap)

prepare commented 7 years ago

please send me the proper way to rebase it :)

prepare commented 7 years ago

@vidstige

Hello!, how are you. 1.Do you mind if I ask you to change NRasterizer to NOpenType?

2.Do you have a plan for a TrueType Instruction VM?

vidstige commented 7 years ago

Hi, Thanks for your contribution! :-) I've been a little sick, but hope to clear up soon, thanks for asking. :-) How are you?

Can you clarify? What should I change? I think I've changed the project name to OpenType. Do you mean the github project?

prepare commented 7 years ago

for nuget package.

I don't generate it. my project (HtmlRenderer) will merge this at source level :) Its easy for me.

If you think that nuget package is useful for every one (I think so) I encourage you to do that. 👍

cheer!

vidstige commented 7 years ago

You rebase as usual.

  1. git fetch
  2. ´git checkout -b my-rebased-branch-name` # create new branch to avoid force pushing
  3. git rebase upstream/master # rebase, this assumes you've got upstream remote setup.

Then you can push the branch as usual. :-)

vidstige commented 7 years ago

Ah, cool. Yeah, I had some problems building it. But the nuspec is checked in.. :-) Can you test it out?

  1. cd NRasterizer
  2. nuget pack NOpenType.nuspec. This will create a .nupkg file.
  3. Add folder as NuGet source in Visual Studio so it can find the package
  4. Install package in your project to test out! :-)
vidstige commented 7 years ago

Superseeded by #29 .

@prepare I still don't get what you mean with the NuGet package? Did my text help you? Could you try the NuGet package?

prepare commented 7 years ago

the current version of PixelFarm/HtmlRenderer will use FontRasterizer at source level. (It is merged into a large one).

no external dependency is one of the requirement of this version

vidstige commented 7 years ago

I think I understand. Thank you for clarifying!