search

vidstige / jadb

ADB Client in pure Java.
Apache License 2.0
640 stars 178 forks source link

Provide deterministic module name for Java 9 module support #137

Open vicasong opened 3 years ago

vicasong commented 3 years ago

Please provide a deterministic module name by adding Automatic-Module-Name to the manifest. See : https://dzone.com/articles/automatic-module-name-calling-all-java-library-maintainers for a rationale.

And now I get an error: Package 'se.vidstige.jadb' is declared in module with an invalid name ('jadb.v1.2.1')

vidstige commented 3 years ago

I didn't know about this, thanks for reporting. I'll look into it if/when I find some time. Feel free to add a pull request if you want to! :)

adamoutler commented 2 years ago

This affects my project as well. I have forked and am maintaining jadb as a part of my Java11 codebase due to lack of module support.

adamoutler commented 2 years ago

I did the work to do the whole upgrade to Java11 here, @vidstige . I closed the PR because it seemed you were not interested. You may use this as a reference. https://github.com/vidstige/jadb/pull/140

vidstige commented 2 years ago

No, I just missed that PR. I don't check in regularly. There are lots of unrelated changes. Also for a library like this it's good to not be on the latest and greatest (this is normally the best) as that prevents people from upgrading this library and so on. I don't know what a reasonable version to be on is. It would be interesting to have some statistics on how widely used Java 11 is.