search

viebel / klipse

Klipse is a JavaScript plugin for embedding interactive code snippets in tech blogs.
http://blog.klipse.tech/
GNU General Public License v3.0
3.1k stars 153 forks source link

when hosting Klipse locally, fonts are loaded from the internet #360

Open lechten opened 4 years ago

lechten commented 4 years ago

Hi, I'm using the master version, following "Host Klipse locally". Differently from #334, I'm using the non-minified version here.

If I add klipse_settings.no_dynamic_scripts=true;, evaluation of code fails with: TypeError: a.split is not a function, while it (almost) works without that setting.

The piece that is not working is that I see a web request for https://viebel.github.io/klipse/fonts/FiraCode/woff/FiraCode-Regular.woff. This request should not be necessary as that resource is part of the dist directory. How can I avoid this?

viebel commented 4 years ago

That's definitely a bug. You can fix it by modifying this file: https://github.com/viebel/klipse/blob/57e5312e88425811183a838f63afd4a92077fada/dist/codemirror.css

Please provide a PR.

lechten commented 4 years ago

I opened a PR for the font issue.

When should klipse_settings.no_dynamic_scripts=true; be necessary?

workshub[bot] commented 3 years ago

@Verdinjoshua26 started working on this issue via WorksHub.

workshub[bot] commented 3 years ago

@rainbow-bamboo started working on this issue via WorksHub.

workshub[bot] commented 2 years ago

A user started working on this issue via WorksHub.