search

viebel / klipse

Klipse is a JavaScript plugin for embedding interactive code snippets in tech blogs.
http://blog.klipse.tech/
GNU General Public License v3.0
3.11k stars 146 forks source link

Use relative, local URLs for fonts. #364

Closed lechten closed 4 years ago

lechten commented 4 years ago

Partially addresses issue #360.

viebel commented 4 years ago

Thanks for your PR @lechten The problem is that files under the dist folder are generated by this build script: https://github.com/viebel/klipse/blob/master/scripts/build#L16

You need to make your modifications in the build script.

lechten commented 4 years ago

The new commit applies the change to the source file that is copied in the build script.

viebel commented 4 years ago

The problem now is that the css is broken in the case where Klipse is not hosted locally. The fix should be in the build script: replace the urls before copying codemirror.css to the dist folder

lechten commented 4 years ago

Ah, I hope this is what you had in mind.

viebel commented 4 years ago

That's exactly what I had in mind. Thank you for improving Klipse