search

viebel / klipse

Klipse is a JavaScript plugin for embedding interactive code snippets in tech blogs.
http://blog.klipse.tech/
GNU General Public License v3.0
3.1k stars 153 forks source link

Python dependency on skulpt.0.10.0.min.js? #397

Closed lechten closed 2 years ago

lechten commented 2 years ago

In this commit the skulpt dependency was changed to 0.10.0. Is that a hard dependency? Only for Python? (In docs/misc/skulpt.html I still see skulpt.min.js without version.)

I would be happy if I could just use skulpt-dist...

viebel commented 2 years ago

I have upgraded skulpt to 0.11.0 I prefer not to use a location where the content is not immutable as it might break Klipse!

For the sake of curiosity what feature of 0.11.0 do you need?

lechten commented 2 years ago

Thank you for your reply! I do not need any specific feature of skulpt, I just include that as dependency for Klipse. I wonder how to do that in a stable way. If you have got a suggestion I'd be happy to read that. Feel free to ignore the remainder...

My environment stopped working when I updated Klipse and version numbers appeared in src/klipse/lang/python.cljs because I did not provide that specific version.

Originally, I was not aware that you ship skulpt in docs/repo/js, which is why I include skulpt-dist (as Git submodule, so I'm free to fix any specific commit/version).

Currently, in addition to the submodule I also copy files with version numbers from docs/repo/js (which I consider bad style as neither origin nor license are visible - I trust that you use unchanged files). This works but is less than ideal.