vieiraf / itg-3200driver

Automatically exported from code.google.com/p/itg-3200driver
GNU Lesser General Public License v3.0
2 stars 2 forks source link

Default address conceptually wrong #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi Felipe,

in my opinion the concept of "default" address when using I2C devices is 
conceptually wrong. There is no default address, that's depends on how your 
breakout board has been designed.. 

You probably wrote this code basing on some breakout board which has a solder 
jumper or something like that.. so you meant by default address the one factory 
enabled in the solder jumper.

I don't think however that this is a correct approach as I think that the 
library should be as more general as possible.. 

So, in the attached patch I removed that and made the I2C address setting 
specific.

Thanks,

Fabio Varesano

Original issue reported on code.google.com by fabio.va...@gmail.com on 22 Jan 2011 at 4:05

Attachments:

GoogleCodeExporter commented 9 years ago
The patch also add an useful INSTALL.txt file.

Original comment by fabio.va...@gmail.com on 22 Jan 2011 at 4:07

GoogleCodeExporter commented 9 years ago
You are right Fabio, but that's a result of using sparkfun breakout “default 
address”... adding your comments makes it clearer. Init(..) was also changed. 
Install.txt added.
Done. (branch filv0.5)

Original comment by fil.vie...@gmail.com on 29 Jan 2011 at 12:22

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thank you!

Original comment by fabio.va...@gmail.com on 29 Jan 2011 at 1:07