search

viennacl / viennacl-dev

Developer repository for ViennaCL. Visit http://viennacl.sourceforge.net/ for the latest releases.
Other
281 stars 89 forks source link

allow for SVD and qr_method to be run on CPUs, this corrects for invalid work sizes #246

Closed cdeterman closed 6 years ago

cdeterman commented 6 years ago

This contains a small change the svd.hpp file that basically checks if the device is a CPU. If it is, then the work sizes are adjusted accordingly otherwise the original defaults are applied.

cdeterman commented 6 years ago

@karlrupp are you accepting pull requests at this time? I know the travis CI is broken so didn't know if that was a current consideration. This should be a relatively minor request herein. I have another I intend to provide to you as well but I don't want it tagging along with this one.

karlrupp commented 6 years ago

@cdeterman thanks for the reminder and the pull request. I'll test and merge early next week, as I'm currently away from a suitable machine.

karlrupp commented 6 years ago

Thanks, @cdeterman , these changes are fine. The implementation of the QR-method should dispatch those calls at a higher level, but that's a much larger refactoring task.