search

vienthuong / shopware-php-sdk

A PHP SDK for Shopware 6 Admin API
MIT License
112 stars 44 forks source link

PHP 8.1 compatibility #53

Closed ChristopherDosin closed 2 years ago

vienthuong commented 2 years ago

Hi my friend @ChristopherDosin Could you describe more which part is not compatible with 8.1 :D Or you will make a PR?

ChristopherDosin commented 2 years ago

Hello my friend @vienthuong :)

Currently the packages requires PHP 8.0 -> https://github.com/vienthuong/shopware-php-sdk/blob/master/composer.json#L15

So this is basically blocking other packages that are requiring PHP 8.1

Not sure if we should just increase it to 8.1, or if we should update the whole code to PHP 8.1 and release a new version?

vienthuong commented 2 years ago

Ah sure, I think for "compatible" I think it's fine enough to add 8.* to the composer.json

ChristopherDosin commented 2 years ago

Perfect. Should i do a PR or do you want to do it? ^^

vienthuong commented 2 years ago

a PR is welcomed :D otherwise I will do it tomorrow or sth, and we should increase the package minor version :)

vienthuong commented 2 years ago

I just released PHP 8.1 compatibility in 1.7.0 version, feel free to reopen ticket if you met any issue with it :)