search

vierge-noire / cakephp-fixture-factories

CakePHP Fixture Factories
https://vierge-noire.github.io/
MIT License
83 stars 21 forks source link

fakerphp 8.2 warnings #194

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

It seems these types of warnings didn't come up when doing https://github.com/vierge-noire/cakephp-fixture-factories/pull/191 but currently I am getting the following deprecation warning with PHP 8.2, vierge-noire/cakephp-fixture-factories 2.7.1 and fakerphp 1.20.0

Deprecated: Use of "static" in callables is deprecated in /app-path/vendor/fakerphp/faker/src/Faker/Provider/Base.php on line 463

There is already a issue present inside faker and a related PR which allegedly fixes those deprecations.

But it also seems that according to https://github.com/FakerPHP/Faker/issues/479#issuecomment-1280062101 there will be breaking changes which will come with the next major release of fakerphp.

Just wanted to ask if you have already looked into this? Since its just coming from the Faker package the only changes we (as Users of this package) would have to make are related to the Faker instance which is passed down to the factory.

LordSimal commented 1 year ago

Seems like at least the deprecation warning has been fixed in https://github.com/FakerPHP/Faker/releases/tag/v1.21.0