search

vierge-noire / cakephp-fixture-factories

CakePHP Fixture Factories
https://vierge-noire.github.io/
MIT License
83 stars 21 forks source link

cakephp 5 update #210

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

~I will need some help here since the created fixtures are not emptied after each test (as far as I can tell)~

Also I removed the src/Command/SetupCommand.php since the FixtureInjector and FixtureManager have been removed.

LordSimal commented 1 year ago

@pabloelcolombiano Do you want me to fix the CS problems in the generated factory classes as well? Otherwise I am done with this. Will leave some comments where I had to change something

pabloelcolombiano commented 1 year ago

Yes fixing the CS check would be appreciated. I think it is only a matter of fully qualified class name. A composer cs-fix might well fix that.

LordSimal commented 1 year ago

A composer cs-fix might well fix that.

This doesn't work because the CS problems occur in the generated Factory classes inside tests/TestApp/tests/Factory/

Therefore I have to fix the generation of the factory class including the correct use statements instead of the FQCN

LordSimal commented 1 year ago

@pabloelcolombiano If you are fine with the changes I introduced to correctly generate factories this should be ready to merge.

pabloelcolombiano commented 1 year ago

I will merge this into a dedicated cake5 branch while Cake5 is still in RC mode.

Thank you very much for the contribution @LordSimal !