search

vierge-noire / cakephp-test-suite-light

A fast test suite for CakePHP applications
MIT License
13 stars 7 forks source link

Truncation policies implementation #22

Closed liqueurdetoile closed 3 years ago

liqueurdetoile commented 3 years ago

Hi again @pabloelcolombiano

Accordingly to #19, I've worked on this PR. I've heavily refactored readme, so I won't say much here except that all truncation behavior is now managed by env vars under the hood with plenty of tools to modify them.

By the way. I've used the main branch as base branch. Is it OK ?

As far as I can say, this PR brings absolutely no breaking changes.

Feel free to amend it at will.

PS : My bad. Gone too fast. Was the good branch but forgot to commit changes ^^

pabloelcolombiano commented 3 years ago

@liqueurdetoile thanks a lot for this very accurate PR. Improving the docs is highly valuable too.

As far as I can see, there is no objection to merge your proposal. My only request would be that the PR be made on the next branch. It is O.K. if you started from main, there should be no issue there.

I have in the pipe to create a contribution section in the docs, my bad.

Therefore, I close this PR, and await a new one on the next branch.