Migrate to go modules - Githubissues

viert / yanpassword

Yandex.Disk-based console password manager

0 stars 1 forks source link

Migrate to go modules #2

Open serejkus opened 5 years ago

serejkus commented 5 years ago

Migrating to go modules will fix following issues:

remove the need for make, project will be built with standard go tooling (go build will fetch missing dependencies and build the binary in a single step).
fix dependencies versions.
make sub-packages usable (now import path is from source root, like import "manager" which makes it unusable and will probably break some tooling, like IDEs/editor plugins).

viert commented 5 years ago

I'd appreciate if you could take a look at my first approach to gomod-based repo (look for gomod branch). Not sure if I do it correctly, at least it definitely breaks my IDE intellisence and path resolving despite being able to build the project smoothly. Probably this is concerned with my environment setup not really suitable for using with go.mod yet

viert commented 5 years ago

Tnx for the PR. Will merge into master shortly

serejkus commented 5 years ago

It looks good, I've added few tiny fixes (c). I've tried working with this project in both Goland and VSCode, both work perfectly. I'm using ms-vscode.go extension for VSCode. Goland requires enabling a flag for using modules (File->Settings->Go->Go Modules(vgo)->Enable Go Modules (vgo) integration.