viest / php-ext-xlswriter

🚀 PHP Extension for creating and reader XLSX files.
https://xlswriter.viest.me
BSD 2-Clause "Simplified" License
2.27k stars 235 forks source link

[1.5.8] API change / BC break #537

Open remicollet opened 6 days ago

remicollet commented 6 days ago

I noticed 2 major API changes in 1.5.8

         Method [ <internal:xlswriter> public method setColumn ] {

-          - Parameters [3] {
-            Parameter #0 [ <required> $format_handle ]
-            Parameter #1 [ <required> $range ]
-            Parameter #2 [ <required> $width ]
+          - Parameters [6] {
+            Parameter #0 [ <required> $range ]
+            Parameter #1 [ <required> $width ]
+            Parameter #2 [ <optional> $format_handle = <default> ]
+            Parameter #3 [ <optional> $level = <default> ]
+            Parameter #4 [ <optional> $collapsed = <default> ]
+            Parameter #5 [ <optional> $hidden = <default> ]
           }
         }

         Method [ <internal:xlswriter> public method setRow ] {

-          - Parameters [3] {
-            Parameter #0 [ <required> $format_handle ]
-            Parameter #1 [ <required> $range ]
-            Parameter #2 [ <required> $height ]
+          - Parameters [6] {
+            Parameter #0 [ <required> $range ]
+            Parameter #1 [ <required> $height ]
+            Parameter #2 [ <optional> $format_handle = <default> ]
+            Parameter #3 [ <optional> $level = <default> ]
+            Parameter #4 [ <optional> $collapsed = <default> ]
+            Parameter #5 [ <optional> $hidden = <default> ]
           }
         }

Not even documented in changelog.

New parameter order will break old code written with version <= 1.5.7

remicollet commented 6 days ago

Looking at change in 1aa4bf683c256ecd1a83e29e9f8e1655dddaf2f9 only ARGINGO were changed Function parameter order is the same, so this seems to be only a bugfix fixing the arginfo