search

viestat / react-native-spotify

A native module that allows you to use the Spotify SDK API with react-native
MIT License
108 stars 23 forks source link

Spotify SDK 23 beta #7

Open moooji opened 8 years ago

moooji commented 8 years ago

Spotify has just released SDK 23 beta and it would be great to support that. It looks like a lot of things have changed though.

SDK is now grouped into Authentication, Metadata and AudioPlayback functionality modules independent from each other. This functionality grouping is reflected in the "Spotify.h" header. SDK will be split into three libraries representing these functionality modules in an upcoming release. Decoupling manifested in that all methods concerning Metadata that previously took a SPTSession object now instead take an NSString *accessToken argument which is a property of the SPTSession object.

moooji commented 8 years ago

I have refactored most parts now so that it works with SDK 23 beta. If you are interested, my current progress can be seen here. I will send a PR, once the README has been updated and I am sure that everything is stable.

https://github.com/moooji/react-native-spotify/tree/sdk-23

digitaldavenyc commented 8 years ago

@moooji @viestat Upgrading the Spotify SDK is actually a pretty critical issue now for this repo. Apple will reject any submissions using a Spotify SDK lower then v20. Apple now requires support for IPV6 and SDK 20 introduced this support. There is a closed issue with Spotify that has this documented, https://github.com/spotify/ios-sdk/issues/676.

react-native-spotify being on SDK 17, is not capable of submitting to the App Store.

I am working with an iOS developer to upgrade our version of the SDK to v20 so we will be able to submit in the meantime.

digitaldavenyc commented 8 years ago

@moooji What areas on your fork still require further work to submit a PR?

ufmemo commented 7 years ago

I'm also keenly interested in seeing this updated to the newer version -- looks like beta-25 was released a couple weeks after the last post here. I would be happy to contribute some time on this, testing documenting, etc.

digitaldavenyc commented 7 years ago

Any ETA on this?

digitaldavenyc commented 7 years ago

@viestat Not sure if you are still aware but this library is not able to published to the App Store as is without an updating Spotify's SDK

https://github.com/spotify/ios-sdk/issues/676