viestat / react-native-spotify

A native module that allows you to use the Spotify SDK API with react-native
MIT License
108 stars 23 forks source link

optional Authorization Code Flow #8

Open moooji opened 8 years ago

digitaldavenyc commented 8 years ago

@moooji This is awesome. I'm going to test it tomorrow and will let you know if there are any issues. I do have some concerns because there is an outstanding bug #6 that could have implications on this PR. Further changes may be required after that bug is fixed.

digitaldavenyc commented 8 years ago

Is this intended to be a starting point for using the beta 23 sdk? Including it sets off a lot of errors on other functions not related to auth.

moooji commented 8 years ago

No this PR should not have to do anything with SDK 23. As you can see in the changes, I have only added "tokenSwapURL" and "tokenRefreshURL" in spotifyModule/ios/SpotifyAuth.m. This should compile without problems with SDK 17.

moooji commented 8 years ago

I have also renamed SpotifyModule -> SpotifyAuth in README, because SpotifyModule does not exist and seem to be some legacy code?